-
Notifications
You must be signed in to change notification settings - Fork 261
chore(deps): update module version to match tag major version #2769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 32.82% 30.91% -1.91%
==========================================
Files 98 103 +5
Lines 26884 28193 +1309
==========================================
- Hits 8824 8717 -107
- Misses 17902 19306 +1404
- Partials 158 170 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for raising the pull request to update the module version. We appreciate your contribution. However, we want to ensure that this change does not have any unintended consequences, We are currently reviewing this in detail to understand the potential impact and identify any necessary mitigations. We will keep you updated on our findings as soon as we complete our analysis. |
Signed-off-by: smcavallo [email protected]
Description
Update module version to match tag version.
The ultimate goal is to allow this module to be published to the go artifact registry
The latest current version there is 2.50.2 which is the last version 2 which was tagged.
See on the registry - https://pkg.go.dev/github.com/newrelic/terraform-provider-newrelic/v2
See the tags - https://github.com/newrelic/terraform-provider-newrelic/releases?page=10
Bumping to /v3 to match the tag version and enable an artifact to be published.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.
How to test this change?
Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc