fix(delete): fix move to trash in read-only folders #8276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
changed the title
nilsding
approved these changes
May 15, 2025
claucambra
approved these changes
May 16, 2025
nilsding
requested changes
May 16, 2025
mgallien
force-pushed
the
bugfix/delayFailingDeleteSyncErrors
branch
3 times, most recently
from
a80a627 to
676cca1
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8276.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
nilsding
approved these changes
May 21, 2025
Signed-off-by: Matthieu Gallien <[email protected]>
QFileInfo::exists(filename) is the fastest method alos avoid creating too many QFileInfo instances when we need it for multiple purposes Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
should improve coverage for move to trash feature to ensure this is working as expected by users Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/delayFailingDeleteSyncErrors
branch
from
676cca1 to
91c8a12
Compare
8 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.