Skip to content

feat: Allow guests to contacts user via public profile "Talk to" link #10542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jonas2515
Copy link

@jonas2515 jonas2515 commented Sep 20, 2023

☑️ Resolves

Depends on nextcloud/server#40288

🚧 Tasks

  • Conversation name should be in recipient language
  • Admin config to disable globally/per-user? (will be done in another PR)
  • Check that API endpoint respects the users profile setting (right now only the button is hidden) feat(profile): Add public interface for profile manager so apps can check config server#41055
  • Make sure the actual conversation is only created on a subsequent POST request. Otherwise like preview generation etc. will randomly create new conversations.

🏁 Checklist

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can afterwards take care of the rebase and adding the admin config as discussed.

@jonas2515 jonas2515 force-pushed the feat/674 branch 2 times, most recently from 50bc93b to 2f86ee5 Compare October 19, 2023 10:15
@nickvergessen
Copy link
Member

Ah, this is still open:

  • Make sure the actual conversation is only created on a subsequent POST request. Otherwise like preview generation etc. will randomly create new conversations.

@nickvergessen
Copy link
Member

Need to check if @DorraJaouad has time at the end of the cycle to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

Website integration/click-to-call
4 participants