Skip to content

Allow docker registry to override fully-qualified container images #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bentsherman
Copy link
Member

Close #6150

@bentsherman bentsherman requested a review from a team as a code owner June 6, 2025 19:16
Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 90ea2d9
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68623f0b05d5600008e53b76
😎 Deploy Preview https://deploy-preview-6178--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale having a separate list of registries? I'm more inclined having this as a flag and use it along with docker.registry when specified to override fully qualified container names, that's the core requirement.

@bentsherman
Copy link
Member Author

A simple flag would be nice but I'm not sure that you could reliably separate the registry part from the container name part without a list of known registries

However, we could just have a flag that fails the run if any fully-qualified container is specified, instead of trying to override. This is because their main requirement is ensuring that Nextflow doesn't try to use any containers outside of docker.registry

@pditommaso
Copy link
Member

I think it would be better to not overload too much the settings for the container registry, and just provide a flag to extend the use of docker.registry to the case of fully qualified container names.

I've provided an implementation in this PR #6205.

]
```

: Nextflow will use this list to modify fully-qualified container images to use the registry specified by `docker.registry`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: Nextflow will use this list to modify fully-qualified container images to use the registry specified by `docker.registry`.
: Nextflow will use this list to modify fully-qualified container images and use the registry specified by `docker.registry`.

Please check meaning is retained

: Nextflow will use this list to modify fully-qualified container images to use the registry specified by `docker.registry`.

: :::{tip}
Use `nextflow inspect` to obtain the list of all containers used by a pipeline, from which you can determine the set of registries that need to be overridden.
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use `nextflow inspect` to obtain the list of all containers used by a pipeline, from which you can determine the set of registries that need to be overridden.
To determine the set of registries that need to be overridden, use `nextflow inspect` to obtain the list of all containers used by a pipeline.

:::

: :::{warning}
The pipeline will fail if a container image cannot be overridden when using this setting, in order to prevent Nextflow from pulling containers from outside the custom registry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The pipeline will fail if a container image cannot be overridden when using this setting, in order to prevent Nextflow from pulling containers from outside the custom registry.
To prevent pulling containers from outside the custom registry, Nextflow will fail the pipeline if it cannot override a container image when using this setting.

Please check the meaning is retained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker.registry needs to override process.container when a registry is used in the container URI
3 participants