-
Notifications
You must be signed in to change notification settings - Fork 700
Allow docker registry to override fully-qualified container images #6178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the rationale having a separate list of registries? I'm more inclined having this as a flag and use it along with docker.registry
when specified to override fully qualified container names, that's the core requirement.
A simple flag would be nice but I'm not sure that you could reliably separate the registry part from the container name part without a list of known registries However, we could just have a flag that fails the run if any fully-qualified container is specified, instead of trying to override. This is because their main requirement is ensuring that Nextflow doesn't try to use any containers outside of |
I think it would be better to not overload too much the settings for the container registry, and just provide a flag to extend the use of I've provided an implementation in this PR #6205. |
] | ||
``` | ||
|
||
: Nextflow will use this list to modify fully-qualified container images to use the registry specified by `docker.registry`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: Nextflow will use this list to modify fully-qualified container images to use the registry specified by `docker.registry`. | |
: Nextflow will use this list to modify fully-qualified container images and use the registry specified by `docker.registry`. |
Please check meaning is retained
: Nextflow will use this list to modify fully-qualified container images to use the registry specified by `docker.registry`. | ||
|
||
: :::{tip} | ||
Use `nextflow inspect` to obtain the list of all containers used by a pipeline, from which you can determine the set of registries that need to be overridden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use `nextflow inspect` to obtain the list of all containers used by a pipeline, from which you can determine the set of registries that need to be overridden. | |
To determine the set of registries that need to be overridden, use `nextflow inspect` to obtain the list of all containers used by a pipeline. |
::: | ||
|
||
: :::{warning} | ||
The pipeline will fail if a container image cannot be overridden when using this setting, in order to prevent Nextflow from pulling containers from outside the custom registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline will fail if a container image cannot be overridden when using this setting, in order to prevent Nextflow from pulling containers from outside the custom registry. | |
To prevent pulling containers from outside the custom registry, Nextflow will fail the pipeline if it cannot override a container image when using this setting. |
Please check the meaning is retained.
Close #6150