Add git response max length #6190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new exception,
HttpResponseLengthExceedException
, to enforce a maximum allowed HTTP response size in theRepositoryProvider
class. It also enhances theSysEnv
utility to support retrieving integer and long environment variables, and adds comprehensive unit tests for these changes.New Exception Handling for HTTP Response Size:
HttpResponseLengthExceedException
to handle cases where an HTTP response exceeds a configurable maximum size. (modules/nextflow/src/main/groovy/nextflow/exception/HttpResponseLengthExceedException.groovy
)RepositoryProvider
:checkMaxLength
method inRepositoryProvider
to validate theContent-Length
header of HTTP responses against the environment variableNXF_GIT_RESPONSE_MAX_LENGTH
. (modules/nextflow/src/main/groovy/nextflow/scm/RepositoryProvider.groovy
) [1] [2]modules/nextflow/src/main/groovy/nextflow/scm/RepositoryProvider.groovy
)Enhancements to
SysEnv
Utility:getInteger
andgetLong
methods to retrieve integer and long values from environment variables with optional default values. (modules/nf-commons/src/main/nextflow/SysEnv.groovy
)Unit Tests:
checkMaxLength
: Added unit tests to validate the behavior ofcheckMaxLength
under various scenarios, including when the maximum length is disabled, not set, or exceeded. (modules/nextflow/src/test/groovy/nextflow/scm/RepositoryProviderTest.groovy
)SysEnv
Enhancements: Added unit tests for the newgetInteger
andgetLong
methods to ensure correct parsing of environment variables. (modules/nf-commons/src/test/nextflow/SysEnvTest.groovy
)