readBytes for non-text files fail for non-GitHub providers. #6243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and failing GiteaRepositoryProviderTest for image readBytes
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
Note that the test for GitHub is passing. You may want to have a deeper look why the Gitea is failing |
|
In the linked issue he also reported Bitbucket is failing, other providers haven't been tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR highlights an issue with the newly exposed readBytes method as described in this issue.
The issue affects Gitea and Bitbucket, and I suspect others too. Likely any that provider that returns raw content, rather than a JSON response containing encoded content, as Github does.