WIP: Capture all comments in parser #6332
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ErikDanielsson
changed the title
|
Notes from today's meeting We will investigate another approach in which the CST is converted directly into a formatting IR and used by the formatter. We can also link CST nodes to AST nodes as needed to retrieve semantic information. But in the first iteration let's see how far we can get with just CST -> formatting IR -> formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR aims to add full support for finding comments in Nextflow source code and attaching them to the appropriate AST node. The additions to the parser are mirrored by the formatter classes used by the language server with the goal of addressing issues with the formatter removing comments.