Skip to content

Simplify plugin download implementation #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pditommaso
Copy link
Member

Summary

Simplifies the plugin download mechanism by removing complex OCI authentication logic and unnecessary file operations.

Changes

  • Removed OciAwareFileDownloader: Deleted the custom OCI-aware downloader class (211 lines removed)
  • Use SimpleFileDownloader: Switched HttpPluginRepository to use the standard SimpleFileDownloader
  • Streamlined PluginUpdater: Removed unnecessary file renaming logic that was redundant
  • Simplified workflow: Plugin download process now has fewer steps and less complexity

Benefits

  • Reduced code complexity and maintenance burden
  • Eliminates potential issues with OCI token authentication
  • More reliable plugin downloads using standard HTTP mechanisms
  • Cleaner, more maintainable codebase

Test plan

  • Verify plugin downloads still work correctly
  • Test plugin installation from various sources
  • Confirm no regression in plugin management functionality

🤖 Generated with Claude Code

- Remove OciAwareFileDownloader class and use SimpleFileDownloader instead
- Remove unnecessary file renaming logic in PluginUpdater
- Streamline plugin download process by removing complex OCI authentication

This simplifies the plugin download mechanism while maintaining core functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 7a35b65
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68a4737e47608e0008a84cd4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants