-
Notifications
You must be signed in to change notification settings - Fork 224
First pass of the Nextflow Run course #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…aining into gvda-nextflow-run
Commands that would be interesting to have in the Nextflow Run training in more detail: For a shorter Nextflow Run:
In case we don't mind length:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I committed a few minor fixes and left some comments/suggestions.
Thank you so much! Really appreciate it. Will address the remaining comments (might be tomorrow). |
I'll do a review today too while I'm on my flight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me. I have some suggestions on the config chapter. My main suggestion is teaching the pattern of running nextflow pipelines in a different work directory than where your code is located. Otherwise this looks great and good-to-go.
Co-authored-by: Ken Brewer <[email protected]>
I addressed Marcel's comments and Ken is on deck, so no need for Marcel to re-review on a Saturday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
All done |
Course outline
planned for later