-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Automatically wrap the definition component on relevant terms #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
S3Prototype
wants to merge
47
commits into
main
Choose a base branch
from
shaquil/doc-267-automatically-wrap-the-definition-component-on-relevant
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Automatically wrap the definition component on relevant terms #1323
S3Prototype
wants to merge
47
commits into
main
from
shaquil/doc-267-automatically-wrap-the-definition-component-on-relevant
+559
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bf5c415
to
0df0fc1
Compare
393748c
to
7ec8d39
Compare
…nent-on-relevant' of https://github.com/ngrok/ngrok-docs into shaquil/doc-267-automatically-wrap-the-definition-component-on-relevant
…ition-component-on-relevant
…nent-on-relevant' of https://github.com/ngrok/ngrok-docs into shaquil/doc-267-automatically-wrap-the-definition-component-on-relevant
…nent-on-relevant' of https://github.com/ngrok/ngrok-docs into shaquil/doc-267-automatically-wrap-the-definition-component-on-relevant
3a08f8f
to
1f0a112
Compare
…nent-on-relevant' of https://github.com/ngrok/ngrok-docs into shaquil/doc-267-automatically-wrap-the-definition-component-on-relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom rehype plugin that wraps the first instance of certain technical terms in a
<Definition>
component automatically. Here's how it looks:example.mp4
Preview here
Because this plugin adds the component automatically, we get this functionality for free everywhere in the docs. This opens up a lot of possibilities:
How to test
Mostly, click around the site and see if the terms listed are highlighted on the pages they appear on.
Terms include:
Considerations
pnpm run dev
. HMR is not slower.