Skip to content

Support Middleman v4.4.x #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ProgrammingIncluded
Copy link

Reproduction

Cannot install library on Middleman 4.4.x due to activerecord version mismatch:

middleman-blog-similar (~> 2.0.1) x64-mingw32 was resolved to 2.0.1, which
depends on
activerecord (~> 5.0, >= 5.0.0) x64-mingw32 was resolved to 5.0.1.rc1,
which depends on
        activesupport (= 5.0.1.rc1) x64-mingw32

    middleman (~> 4.4.2) x64-mingw32 was resolved to 4.4.2, which depends on
middleman-core (= 4.4.2) x64-mingw32 was resolved to 4.4.2, which depends
on
        activesupport (>= 6.1, < 7.0) x64-mingw32

Fix

  • Bump activerecord to >= 6.1 which auto updates activesupport >= 6.1
  • Modify article.rb to use new API: to_hash -> to_ary
  • Update middleman-blog-similar VERSION to 2.1.0 due to dependency upgrade.

Possible Issues

  • Not sure if middleman version 4.4.x is the minimum version for activesupport >= 6.1.
  • Have not tested initialization code for possible API breakage due to existing SQL database.

This PR was created with minimal testing. Please use as much or as little as possible for the changes. I have found your library to be very helpful so would appreciate it being updated to support latest middleman.

Best,
PI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant