REF: Refactor motion-related data computation functions #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
ref/refactor-fd-funct-pet-nb
branch
4 times, most recently
from
b3b6e5b to
d2810bf
Compare
|
I'm leaving writing testing functions for a separate PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 74.00% 73.52% -0.49%
==========================================
Files 24 24
Lines 1404 1420 +16
Branches 166 166
==========================================
+ Hits 1039 1044 +5
- Misses 299 310 +11
Partials 66 66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhlegarreta
commented
Jul 25, 2025
| return np.sum(np.abs(d_translations) + np.abs(rotation_displacement), axis=1) | ||
|
|
||
|
|
||
| def extract_motion_parameters(affine: np.ndarray) -> Tuple[np.ndarray, np.ndarray]: |
There was a problem hiding this comment.
Not sure if this module is the most appropriate place for this function.
jhlegarreta
force-pushed
the
ref/refactor-fd-funct-pet-nb
branch
2 times, most recently
from
b086604 to
0426355
Compare
jhlegarreta
force-pushed
the
ref/refactor-fd-funct-pet-nb
branch
from
0426355 to
04a5ac9
Compare
Refactor motion-related data computation functions into reusable code from the PET notebook. Rename the existing FD function to distinguish it from the refactored function.
jhlegarreta
force-pushed
the
ref/refactor-fd-funct-pet-nb
branch
from
04a5ac9 to
aec5793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor motion-related data computation functions into reusable code from the PET notebook.
Rename the existing FD function to distinguish it from the refactored function.