STY: Re-use and define global variables for dMRI model #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhlegarreta
commented
Aug 12, 2025
jhlegarreta
commented
- STY: Re-use the lower-bound b and S0 thresholds from dMRI data module
- STY: Define the S0 clipping percentile as a global variable
jhlegarreta
force-pushed
the
sty/misc-dmri-model-fixes2
branch
from
b815683 to
ece34d6
Compare
jhlegarreta
commented
Aug 12, 2025
| @@ -79,7 +79,7 @@ def __init__(self, dataset: DWI, max_b: float | int | None = None, **kwargs): | |||
| f"DWI dataset is too small ({dataset.gradients.shape[0]} directions)." | |||
| ) | |||
|
|
|||
| if max_b is not None and max_b > B_MIN: | |||
| if max_b is not None and max_b > DEFAULT_LOWB_THRESHOLD: | |||
There was a problem hiding this comment.
Note that as explained in cd9f6ca, the b0 lower bound is changed from 1e-6 to 1e-5.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 24 24
Lines 1402 1402
Branches 166 166
=======================================
Hits 1037 1037
Misses 299 299
Partials 66 66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Re-use the lower-bound b and S0 thresholds from dMRI data module in the dMRI model for the sake of consistency. The data module minimum S0 value is 1e-5 as opposed to the 1e-6 value that was being used in the model module.
Define the S0 clipping percentile in the dMRI model as a global variable and document its purpose.
jhlegarreta
force-pushed
the
sty/misc-dmri-model-fixes2
branch
from
ece34d6 to
6a26bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.