Skip to content

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Aug 18, 2025

Inherit base model class from ABC to enforce native abstraction.

Fixes:

Abstract methods are allowed in classes whose metaclass is 'ABCMeta'

raised locally by the IDE.

@jhlegarreta jhlegarreta force-pushed the ref/inherit-abstract-from-abc branch from 9de29da to 14a7998 Compare August 18, 2025 02:26
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.96%. Comparing base (19af931) to head (62f866c).

Files with missing lines Patch % Lines
src/nifreeze/model/base.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   74.00%   73.96%   -0.04%     
==========================================
  Files          24       24              
  Lines        1404     1406       +2     
  Branches      166      166              
==========================================
+ Hits         1039     1040       +1     
- Misses        299      300       +1     
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhlegarreta jhlegarreta force-pushed the ref/inherit-abstract-from-abc branch 5 times, most recently from 8a2c1c5 to c07c59e Compare August 22, 2025 22:49
Inherit base model class from `ABC` to enforce native abstraction.

Fixes:
```
Abstract methods are allowed in classes whose metaclass is 'ABCMeta'
```

raised locally by the IDE.
@jhlegarreta jhlegarreta force-pushed the ref/inherit-abstract-from-abc branch from c07c59e to 62f866c Compare August 22, 2025 22:50
@jhlegarreta jhlegarreta changed the title REF: Inherit base model class from ABC to enforece native abstraction REF: Inherit base model class from ABC to enforce native abstraction Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant