-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add gitlab integration #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Looks ok so far. |
|
||
|
||
class CreateGitlabProjectHooks(ThreadDeferredBuildStep): | ||
name = "create_gitlab_project_hooks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. if gitlab has a different way to install webhooks i.e. through some app interface, this might be preferred. It's a bit of a historical accident in github that we didn't just use the webhooks that are provided by a github app rather than installing an explicit webhook into each repository.
Ooo, I'm eager to have this. I've been building all my Nix targets using a dynamic fan-out Pipeline in Gitlab CI right now. It's working OK, but I know there are significant efficiencies that this Buildbot config uses and I can't wait to taste them. |
@greg-hellings maybe you can team up with @wlcx |
@Mic92 Happily! I can definitely look at the list of things he has above still TBD. I'm in the midst of migrating hypervisors, so you won't see me back on Matrix over this weekend. I should be there Monday to collaborate on this. |
b562dce
to
017c0a9
Compare
This is a draft currently as there's some tyre kicking still to do, but I thought it was worth putting up for some initial thoughts!
resolves #329
Still to do: