Skip to content

support more temporal parameters and geometry types in queries #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ninsbl
Copy link

@ninsbl ninsbl commented May 8, 2025

This PR adds support for using revision_date, created_at, and production_date as temporal filter parameters. It also adds point, line, and polygon as supported geometry types for spatial queries.

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--1007.org.readthedocs.build/en/1007/

Copy link

github-actions bot commented May 8, 2025

Binder 👈 Launch a binder notebook on this branch for commit 2f8452c

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit d2010d2

Binder 👈 Launch a binder notebook on this branch for commit 9410217

Binder 👈 Launch a binder notebook on this branch for commit 86a8a27

Binder 👈 Launch a binder notebook on this branch for commit 94e54a1

Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninsbl, thank you for your contribution.

At the moment, I'm marking this as "request changes" without any requested changes yet, as I want to first bring this to the attention of others, because these changes touch upon a recurring discussion where we have not yet come to a decision.

The discussion is in regard to the relationship between the earthaccess and python_cmr libraries. The changes you propose don't add functionality, but rather "surface" documentation for existing functionality that is currently less than obvious.

I hesitate to approve these changes only because they potentially add to our existing technical debt in the context of the discussed relationship between the 2 libraries.

Here are a few places where the relationship is mentioned:

I'm copying others who have been involved in this discussion so that they can weigh in as well.

cc: @betolink, @mfisher87, @jhkennedy, @itcarroll

@ninsbl
Copy link
Author

ninsbl commented May 8, 2025

At the moment, I'm marking this as "request changes" without any requested changes yet, as I want to first bring this to the attention of others, because these changes touch upon a recurring discussion where we have not yet come to a decision.

Thanks, @chuckwondo ! Fully appreciate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants