-
Notifications
You must be signed in to change notification settings - Fork 106
support more temporal parameters and geometry types in queries #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I will automatically update this comment whenever this PR is modified
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ninsbl, thank you for your contribution.
At the moment, I'm marking this as "request changes" without any requested changes yet, as I want to first bring this to the attention of others, because these changes touch upon a recurring discussion where we have not yet come to a decision.
The discussion is in regard to the relationship between the earthaccess
and python_cmr
libraries. The changes you propose don't add functionality, but rather "surface" documentation for existing functionality that is currently less than obvious.
I hesitate to approve these changes only because they potentially add to our existing technical debt in the context of the discussed relationship between the 2 libraries.
Here are a few places where the relationship is mentioned:
- Most specifically here: should earthaccess provide a way to keep track of input query parameters? #847 (comment)
- Are we providing a coherent user experience regarding `search` and `open`? #926
- Support multiple-point searches #491
- Support pattern matching on arbitraty parameters for granule searches #198
search_data
&search_datasets
documentation parameter list is incomplete #345
I'm copying others who have been involved in this discussion so that they can weigh in as well.
cc: @betolink, @mfisher87, @jhkennedy, @itcarroll
Thanks, @chuckwondo ! Fully appreciate. |
This PR adds support for using revision_date, created_at, and production_date as temporal filter parameters. It also adds point, line, and polygon as supported geometry types for spatial queries.
Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1
. SeeGitHub docs - Linking a pull request to an issue.
CHANGELOG.md
with details about your change in a section titled## Unreleased
. If such a section does not exist, please create one. FollowCommon Changelog for your additions.
Example PRs: #763
README.md
with details of changes to theearthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-support
team in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--1007.org.readthedocs.build/en/1007/