Skip to content

fix(lint): Update golangci-lint to v2 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thunderboltsid
Copy link
Contributor

migrate golangci-lint config using built-in migrate tooling.

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve tests

migrate golangci-lint config using built-in migrate tooling.
@thunderboltsid thunderboltsid force-pushed the issue/golangcilint-v2 branch from e713a83 to 812d146 Compare May 6, 2025 19:30
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (883f3c9) to head (812d146).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
controllers/nutanixmachine_controller.go 23.52% 13 Missing ⚠️
controllers/nutanixcluster_controller.go 40.00% 3 Missing ⚠️
controllers/helpers.go 50.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (30.76%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   43.96%   44.00%   +0.03%     
==========================================
  Files          18       18              
  Lines        2593     2593              
==========================================
+ Hits         1140     1141       +1     
- Misses       1417     1418       +1     
+ Partials       36       34       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thunderboltsid thunderboltsid requested a review from fatz May 6, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants