Skip to content

Move app configuration into service configuration #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented May 12, 2025

Contents (#730)

IMPORTANT: There is 1 breaking change.

New features

  • 💥 BREAKING CHANGE: Move app configuration into service configuration

Upgrade instructions

💥 Move app configuration into service configuration
  • Move the contents of the app_configuration.json file into the octue.yaml file under the first item in the services list (make sure to convert from JSON to YAML)
  • Remove the app_configuration_path argument from the octue.yaml file
  • Use ServiceConfiguration.from_file instead of load_service_and_app_configuration
  • Replace any uses of the app_configuration argument/variable with service_configuration

BREAKING CHANGE: Move the contents of the `app_configuration.json` file into the `octue.yaml` file under the first item in the `services` list. Replace any uses of the `app_configuration` argument/variable with `service_configuration` and use `ServiceConfiguration.from_file` instead of `load_service_and_app_configuration`.
@cortadocodes cortadocodes self-assigned this May 12, 2025
@cortadocodes cortadocodes linked an issue May 12, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (cd8a6ca) to head (6ecfd61).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   94.05%   94.12%   +0.06%     
==========================================
  Files          85       85              
  Lines        3685     3659      -26     
==========================================
- Hits         3466     3444      -22     
+ Misses        219      215       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cortadocodes cortadocodes merged commit ab2639b into main May 12, 2025
5 checks passed
@cortadocodes cortadocodes deleted the remove-app-configuration branch May 12, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove app configuration
2 participants