Skip to content

Fix eth_signTypedData #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

Fix eth_signTypedData #2161

wants to merge 59 commits into from

Conversation

jribbink
Copy link
Contributor

No description provided.

jribbink and others added 30 commits January 27, 2025 10:30
@jribbink
Create FCL Ethereum Provider Boilerplate
d6f3010
@jribbink
Fix CI (#2077)
05c441d
@jribbink
Add FCL Etheruem Provider AccountManager stub (#2078)
4af4ae4
@chasefleming
Setup eth accounts handler (#2079)
1452dc0 
* Setup eth accounts handler

* Run prettier

---------

Co-authored-by: Chase Fleming <[email protected]>
@jribbink
Add fallback gateway (#2083)
64487ca
@chasefleming
Implement eth request accounts (#2088)
8c69e9c 
* Implement eth_requestAccounts

* Add handler code

* Pass account manager and use

* Set coa address

* Move coa fetcher

* Remove comment

* Only check if changed

* Stop race conditions

* Fix types and update address

* Add basic tests

* Fix

* Use mock user

* Add test

* Add more tests

* Add test

* Add test

* Add test

* Add test

* Add test

* Add tests

* Import

* Fix prettier

* Fix prettier

---------

Co-authored-by: Chase Fleming <[email protected]>
@jribbink
Implement eth_sendTransaction RPC Method (#2089)
d651fd2
@jribbink
Implement FCL Ethereum Provider accountsChanged Event (#2091)
5c9de12
@chasefleming
Return unsubscribe from account manager (#2094)
a9659aa 
Co-authored-by: Chase Fleming <[email protected]>
@chasefleming @jribbink
Implement personal_sign (#2095)
2fda71b 
* Add sign message

* Update packages/fcl-ethereum-provider/src/accounts/account-manager.ts

Co-authored-by: Jordan Ribbink <[email protected]>

* Push fix

* Remove comment

* Update packages/fcl-ethereum-provider/src/rpc/handlers/personal-sign.ts

Co-authored-by: Jordan Ribbink <[email protected]>

* Update packages/fcl-ethereum-provider/src/accounts/account-manager.ts

Co-authored-by: Jordan Ribbink <[email protected]>

* Update packages/fcl-ethereum-provider/src/rpc/handlers/personal-sign.ts

Co-authored-by: Jordan Ribbink <[email protected]>

* Check auth with coa address

* Add tests

* Fix params and prettier

* Run prettier

* Use RLP

* Change path

* hex array

* Fix RLP test

* Run prettier

---------

Co-authored-by: Chase Fleming <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
@jribbink
Implement Reactive State Management using Observabales (#2098)
167277e
@jribbink
Implement FCL Ethereum Provider chainChanged Event (#2096)
b2f9026
@jribbink
Implement provider connect event (#2090)
4c7ec61
@chasefleming @jribbink
Add eth_signTypedData (#2097)
29d7f07 
* Add eth signed typed data

* Fix

* Run prettier

* Add tests

* Run prettier

* Remove comment

* Match hashing closer to spec

* Use util

* Fix tests

* Run prettier

* Remove legacy support

* Update packages/fcl-ethereum-provider/src/hash-utils.ts

Co-authored-by: Jordan Ribbink <[email protected]>

* Fix test

---------

Co-authored-by: Chase Fleming <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
@jribbink
Add check for from address in AccountManager.sendTransaction (#2103)
4829b5a
@chasefleming
Add noop for add eth chain (#2106)
7bb563b 
* Add noop for add eth chain

* Run prettier

---------

Co-authored-by: Chase Fleming <[email protected]>
@chasefleming
Add typed params for wallet_addEthereumChain (#2109)
9a57857 
* Add typed params for wallet_addEthereumChain

* Run prettier

---------

Co-authored-by: Chase Fleming <[email protected]>
@chasefleming
Implement wallet_switchEthereumChain (#2111)
31df38b 
* Implement wallet_switchEthereumChain

* Run prettier

---------

Co-authored-by: Chase Fleming <[email protected]>
@jribbink
Handle eth_chainId Locally in FCL Ethereum Provider (#2116)
2d651a3
@chasefleming
Setup disconnect (#2119)
e3dae26 
* Move to account manager

* Setup disconnect

* Run prettier

* Fix test

* Remove import

* Push fix

* Push fix

---------

Co-authored-by: Chase Fleming <[email protected]>
@jribbink
Add EVM contract address to scripts (#2121)
d11dd4e
@chasefleming
Create COA on request accounts (#2120)
e37469b 
* Create COA on request accounts

* Add tests

* Fix test

* Remove

* Update test

* Refactor

* Add events

* Fix tests

* Run prettier

* Fix

* Move tx

* Move cadence

---------

Co-authored-by: Chase Fleming <[email protected]>
@jribbink
Adhere to EIP-1193 / EIP-1474 Error Format (#2117)
d8d7523
@jribbink
Fix testnet chain ID (#2124)
5cead72
@jribbink
Merge branch 'master' into feature/cross-vm
aa0a5a3
@chasefleming
Add UI for storage error (#2126)
b4b3e1b 
* Add UI for storage error

* Use shadow dom

---------

Co-authored-by: Chase Fleming <[email protected]>
@jribbink
Add Boilerplate Wagmi & Rainbowkit Adapter (#2105)
b81429b
@chasefleming @jribbink
Precalulate tx hash (#2130)
b9e9510 
* wip

* Add nonce script

* Add get Nonce

* Remove

* Change

* Run prettier

* Switch to bigint

* Remove and add test

* Remove

* Update tests

* Run prettier

* Fix test

* Move tests

* Run prettier

* Update packages/fcl-ethereum-provider/src/accounts/sign-message.test.ts

Co-authored-by: Jordan Ribbink <[email protected]>

---------

Co-authored-by: Chase Fleming <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
@chasefleming
Clean up prefix handling (#2132)
070f216 
* Clean prefix handling

* Run prettier

---------

Co-authored-by: Chase Fleming <[email protected]>
@jribbink
Fix eth_sendTransaction (#2134)
4057abd
chasefleming and others added 14 commits February 13, 2025 16:48
@chasefleming @jribbink
Implement disconnected spec (#2141)
5a9f98f 
* Implement disconnected spec

* Fix disconnected

* Fix error

* Fix

* Update packages/fcl-wagmi-adapter/src/index.ts

Co-authored-by: Jordan Ribbink <[email protected]>

* Update packages/fcl-wagmi-adapter/src/index.ts

Co-authored-by: Jordan Ribbink <[email protected]>

* Fix

---------

Co-authored-by: Chase Fleming <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
@jribbink
Create Flow Wallet Connector (#2146)
8ffcc1b
@jribbink
Update Rainbowkit instructions (#2149)
c93d497
@jribbink
Make FCL Ethereum provider associative (#2150)
e843d56
@jribbink
Remove panic from Cadence TX (#2153)
f691a8c
@jribbink
Add WalletConnect support (#2133)
b010de2
@jribbink
Add changesets & enter pre-release mode (#2154)
e8f5585
@github-actions
Version Packages (cross-vm) (#2155)
297bb09 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jribbink
Revert "Version Packages (cross-vm) (#2155)" (#2156)
2865953 
This reverts commit 297bb09.
@github-actions @jribbink
Version Packages (cross-vm) (#2157)
1790278 
* Version Packages (cross-vm)

* Switch to v0.0.1 release

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jordan Ribbink <[email protected]>
@jribbink
Disable version bump check
542b87c
@jribbink
Fix tests
6836236
@jribbink
Fix code formatting
ea6d6d4
@jribbink
Fix eth_signTypedData
2697118
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b938441

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink changed the base branch from master to feature/cross-vm February 22, 2025 08:08
jribbink and others added 8 commits February 26, 2025 08:57
@jribbink
Fix gas estimation fallback in eth_sendTransaction (#2163)
449d566
@github-actions
Version Packages (cross-vm) (#2164)
1bdcde3 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jribbink
Pin package versions
86bb549
@jribbink
changeset
24a39f3
@github-actions
Version Packages (cross-vm) (#2165)
a2dfa38 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jribbink
Fix eth_estimateGas prefixing
aa36c67
@github-actions
Version Packages (cross-vm) (#2166)
225a2c2 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jribbink
Fix test
5d538ed
@jribbink jribbink marked this pull request as ready for review March 6, 2025 00:12
@jribbink jribbink requested a review from a team as a code owner March 6, 2025 00:12
@jribbink jribbink changed the title Jribbink/sign typed data fix Fix eth_signTypedData Mar 6, 2025
Base automatically changed from feature/cross-vm to master March 31, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jribbink @chasefleming