Fix existing followed assets not getting listed after search Reindexing #22621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonika-shah
added
safe to test
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where followed assets were not being listed after search reindexing by implementing proper batch fetching for the followers field. The issue was that the field support mapping for followers was missing, causing bulk operations to not properly populate follower information.
- Added batch fetch method for followers field to enable efficient bulk loading
- Enhanced test validation to verify followers field consistency between bulk and individual operations
- Fixed the missing field support mapping registration for followers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| EntityRepository.java | Added batch followers fetching implementation and registered field support mapping |
| EntityResourceTest.java | Enhanced test validation for followers field consistency and data integrity |
Comments suppressed due to low confidence (1)
openmetadata-service/src/test/java/org/openmetadata/service/resources/EntityResourceTest.java:903
- The test assumes getFollowers() method exists and returns List, but this may not be consistent across all entity types. Consider using a more generic approach or add null checks to handle cases where the method might not be available.
List<EntityReference> bulkFollowers = entity.getFollowers();
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java
Outdated
Show resolved
Hide resolved
harshach
previously approved these changes
Jul 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Add batch fetch methods for missing fields
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>