mpi-rma: embiggen second level mpi rma support infrastructure #13288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top level API files generated by the bindings generation code and the lower level OSC frameworks have been embiggened previously, but the middle layer within OMPI has not been till this patch. There's a present for the RMA WG in this commit in the form of a comment. Something for them to work on. Related to open-mpi#13151 Signed-off-by: Howard Pritchard <[email protected]>
devreal
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Thanks @hppritcha for flagging this. We'll discuss this in the RMA WG 👍
Comment on lines
+223
to
+228
| /* | ||
| * No this isn't really right but the MPI Forum RMA WG was spleeping during | ||
| * Big count proposal reading and didn't put in something for Table 12.1 of the | ||
| * MPI 5.0 standard for embiggened disp_unit, so here we go with int * in accordance | ||
| * with that table. | ||
| */ |
|
I don't know why you use I would change this back and make |
|
With big count |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top level API files generated by the bindings generation code and the lower level OSC frameworks have been embiggened previously, but the middle layer within OMPI has not been till this patch.
There's a present for the RMA WG in this commit in the form of a comment. Something for them to work on.
Related to #13151