Add NTRU back #2176
Open
Add NTRU back #2176
+249,531
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitomst
requested review from
baentsch,
bhess,
alexrow,
praveksharma and
dstebila
as code owners
|
A test of the pull request test suite is failing on the Docker pull phase. Can anyone re-run the test? |
ashman-p
approved these changes
Jul 4, 2025
praveksharma
approved these changes
Aug 13, 2025
This commit includes following changes: * Revert "Removed NTRU. (open-quantum-safe#1335)" * Replace the uses of malloc with OQS_MEM_malloc * Add a derandomized keypair function * Add "all" entries of NTRU algorithms to the KATs file * Fix reflecting the removal of NTRU from PQClean * Update NTRU documents with the latest manners * Change the CODEOWNERS of NTRU KEM Signed-off-by: Saito Masataka <[email protected]>
|
I rebased my branch onto the latest main to resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revives NTRU, which was included up to version 0.72.
This PR resolves #2097. In the event that NTT discontinues maintenance in the future, we would have no objections if liboqs discontinued support for NTRU.
Summary of Changes:
Restore the removed NTRU implementation while adapting it to the latest environment.
Change the CODEOWNERS of NTRU KEM, taking responsibility for its maintenance.
Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)
Thank you for reviewing this contribution and for your time. If you have any feedback, we're always happy to make adjustments. This PR was prepared in collaboration with Akira Nagai from NTT.