Correct the patch-submission docs #22
Conversation
✅ Deploy Preview for fluffy-chebakia-3fa329 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
README.md
Outdated
| * Patches should be submitted via a pull-request at | ||
| https://github.com/open-source-firmware/flat-image-tree/pulls | ||
| * Sign up to the mailing list at https://lists.osfw.foundation/g/flat-image-tree |
There was a problem hiding this comment.
suggestion (non-blocking): reorder
It's a bit odd to say to use the mailing list for things A, but patches another way, but hey this is how to sign up to the mailing list.
I would suggest to reorder the list such that
Patches should be submitted via a pull-request at https://github.com/open-source-firmware/flat-image-tree/pulls
be either first or last in the list.
There was a problem hiding this comment.
done, I think, but please check that I understood you correctly.
README.md
Outdated
| * Patches should be submitted via a pull-request at | ||
| https://github.com/open-source-firmware/flat-image-tree/pulls |
There was a problem hiding this comment.
suggestion (non-blocking): deduplicate info
The Contributions section already explains how it's done (plus some more info), so maybe avoid to repeat it here so we don't get contradicting info.
You could instead use a link something like
For patches, please read the [Contributions section](#contributions)We are using pull-requests now, not patches, so update the docs to be consistent with that. Signed-off-by: Simon Glass <[email protected]> Reported-by: Quentin Schulz <[email protected]> Fixes: #19
|
LGTM |
|
Thanks for helping with this! |
We are using pull-requests now, not patches, so update the docs to be consistent with that.