Skip to content

[pipeline] Dreprecate MustNewID and MustNewIDWithName #12835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Apr 14, 2025

Updates #12831

@bogdandrutu bogdandrutu requested a review from a team as a code owner April 14, 2025 17:31
@bogdandrutu bogdandrutu requested a review from atoulme April 14, 2025 17:31
@bogdandrutu bogdandrutu force-pushed the deprecate-pipeline-must branch from 6cd2a16 to 67389ee Compare April 14, 2025 17:32
@bogdandrutu bogdandrutu force-pushed the deprecate-pipeline-must branch from 67389ee to 4511e79 Compare April 14, 2025 17:42
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.43%. Comparing base (28ca163) to head (4511e79).

Files with missing lines Patch % Lines
pipeline/pipeline.go 71.42% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (92.30%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12835   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files         488      488           
  Lines       26879    26880    +1     
=======================================
+ Hits        24577    24578    +1     
  Misses       1818     1818           
  Partials      484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Apr 21, 2025
@bogdandrutu bogdandrutu removed this pull request from the merge queue due to a manual request Apr 21, 2025
@bogdandrutu
Copy link
Member Author

@mx-psi do you want to fix contrib first to not use the ids in the wrong way?

@mx-psi
Copy link
Member

mx-psi commented Apr 22, 2025

@mx-psi do you want to fix contrib first to not use the ids in the wrong way?

If we can do it before merging then yes, I think we should do it first on contrib and then merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants