-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[pipeline] Dreprecate MustNewID and MustNewIDWithName #12835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[pipeline] Dreprecate MustNewID and MustNewIDWithName #12835
Conversation
6cd2a16
to
67389ee
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
67389ee
to
4511e79
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (92.30%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12835 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 488 488
Lines 26879 26880 +1
=======================================
+ Hits 24577 24578 +1
Misses 1818 1818
Partials 484 484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mx-psi do you want to fix contrib first to not use the ids in the wrong way? |
If we can do it before merging then yes, I think we should do it first on contrib and then merge this |
Updates #12831