Skip to content

[confmap] Correctly distinguish between empty and nil slices #12872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 16, 2025

Description

A second attempt at #11882.

Note that I added some tests in #12871 to prevent something like #12661 from happening again.

Link to tracking issue

Fixes #11749

Testing

See tests from #12871 as well as the new tests added here.

@github-actions github-actions bot requested a review from evan-bradley April 16, 2025 14:49
@mx-psi mx-psi marked this pull request as ready for review April 16, 2025 16:12
@mx-psi mx-psi requested a review from a team as a code owner April 16, 2025 16:12
@mx-psi mx-psi requested a review from yurishkuro April 16, 2025 16:15
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (78663f9) to head (05e91fe).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12872   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         494      494           
  Lines       26993    27006   +13     
=======================================
+ Hits        24691    24704   +13     
  Misses       1818     1818           
  Partials      484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yurishkuro
Copy link
Member

cc @mahadzaryab1

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi added this pull request to the merge queue Apr 21, 2025
Merged via the queue into open-telemetry:main with commit bac08e2 Apr 21, 2025
56 checks passed
@mx-psi mx-psi deleted the mx-psi/nil-empty-slices branch April 21, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour of ToStringMap Not Matching Confmap Decoding Workflow
5 participants