-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[payment/frontend/flagd-ui]: replace alpine with distroless image #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend is crashing with the following error:
TypeError: Cannot read properties of undefined (reading 'setAttribute')
at <unknown> (.next/server/chunks/707.js:1:837)
The payment is not crashing, but no OTel data is being sent.
I do see logs like:
{"level":"info","time":1750157799195,"pid":1,"hostname":"ac022eeb90b9","service.name":"payment","transactionId":"42c3bad6-103e-4fbf-9d68-08d7b4a5c416","cardType":"visa","lastFourDigits":"3547","amount":{"units":{"low":1443,"high":0,"unsigned":false},"nanos":699999994,"currencyCode":"USD"},"loyalty_level":"bronze","msg":"Transaction complete."}
But the traces are exported.
Flagd-ui seems to be working fine.
Hey @Red-GV sorry for taking that long to review. |
No problem at all @julianocosta89 . I'll try to take a look at what's going on later this week. |
Haven't tested these changes yet, but wanted to update this branch in the interim. |
Heads up @julianocosta89 , I've cherry-picked a commit from this PR into another PR. I believe this commit should fix the problems with the building of the protobuf files and allow the Dependabot's attempt to update the packages to at least go into the building state. |
Signed-off-by: Gerard Vanloo <[email protected]>
…d dependencies Signed-off-by: Gerard Vanloo <[email protected]>
Signed-off-by: Gerard Vanloo <[email protected]>
Signed-off-by: Gerard Vanloo <[email protected]>
Signed-off-by: Gerard Vanloo <[email protected]>
Signed-off-by: Gerard Vanloo <[email protected]>
Changes
This PR changes the alpine image with a distroless one.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.