Skip to content

[payment/frontend/flagd-ui]: replace alpine with distroless image #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented May 29, 2025

Changes

This PR changes the alpine image with a distroless one.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@Red-GV Red-GV requested a review from a team as a code owner May 29, 2025 18:46
@Red-GV
Copy link
Contributor Author

Red-GV commented May 29, 2025

Image size changes can be seen here.

Screenshot 2025-05-29 at 2 44 59 PM

Copy link

github-actions bot commented Jun 6, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend is crashing with the following error:

TypeError: Cannot read properties of undefined (reading 'setAttribute')
    at <unknown> (.next/server/chunks/707.js:1:837)

The payment is not crashing, but no OTel data is being sent.
I do see logs like:

{"level":"info","time":1750157799195,"pid":1,"hostname":"ac022eeb90b9","service.name":"payment","transactionId":"42c3bad6-103e-4fbf-9d68-08d7b4a5c416","cardType":"visa","lastFourDigits":"3547","amount":{"units":{"low":1443,"high":0,"unsigned":false},"nanos":699999994,"currencyCode":"USD"},"loyalty_level":"bronze","msg":"Transaction complete."}

But the traces are exported.

Flagd-ui seems to be working fine.

@julianocosta89
Copy link
Member

Hey @Red-GV sorry for taking that long to review.

@Red-GV
Copy link
Contributor Author

Red-GV commented Jun 17, 2025

No problem at all @julianocosta89 . I'll try to take a look at what's going on later this week.

@Red-GV
Copy link
Contributor Author

Red-GV commented Jun 18, 2025

Haven't tested these changes yet, but wanted to update this branch in the interim.

@Red-GV
Copy link
Contributor Author

Red-GV commented Jun 19, 2025

Heads up @julianocosta89 , I've cherry-picked a commit from this PR into another PR. I believe this commit should fix the problems with the building of the protobuf files and allow the Dependabot's attempt to update the packages to at least go into the building state.

@Red-GV Red-GV marked this pull request as draft June 19, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants