Skip to content

Rename StackDrive to GoogleCloud and update libraries to latest version #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bielu
Copy link

@bielu bielu commented Jun 24, 2025

Fixes #1170 #1423 #1263
Design discussion issue #

Changes

Changes make sure that package is more aligned with Google naming and using latest version of libraries for GCP connectivity.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link

linux-foundation-easycla bot commented Jun 24, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient labels Jun 24, 2025
@Kielek
Copy link
Contributor

Kielek commented Jun 24, 2025

@SergeyKanzhelev - could you please check, if you are fine with these changes?

@bielu
Copy link
Author

bielu commented Jun 24, 2025

@Kielek I am still working on this one it is why I opened it as draft, but wanted make sure it is visible so there is no other prs open doing same bits and bobs :)

@Kielek
Copy link
Contributor

Kielek commented Jun 24, 2025

@bielu, it is a question for a perspective from the component owner. Renaming package is a big change. The early feedback is better than when everything is ready.

@bielu
Copy link
Author

bielu commented Jun 24, 2025

@Kielek that's right. However it sensible to rename it to match GCP naming convention as they renamed stackdrive long time ago, so when I googled with "gcp traces" / "google cloud open telemetry" i couldn't find it in first place because of name mismatch :)

@bielu
Copy link
Author

bielu commented Jun 25, 2025

@SergeyKanzhelev I implemented now GoogleCloudMetricsExporter to make provider more feature completed, however still not tagging it as ready for review as I would love to get some feedback on this class as it was written with AI support and I am not as familar with Exporters in OTLP. I compared it towards go version:
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go
and they do similarly things so it should be okay to go, but yeah would prefer to confirm if that's how you expect it to be written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename OpenTelemetry.Exporter.Stackdriver to align with the Google Cloud product name
2 participants