-
Notifications
You must be signed in to change notification settings - Fork 336
Rename StackDrive to GoogleCloud and update libraries to latest version #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@SergeyKanzhelev - could you please check, if you are fine with these changes? |
@Kielek I am still working on this one it is why I opened it as draft, but wanted make sure it is visible so there is no other prs open doing same bits and bobs :) |
@bielu, it is a question for a perspective from the component owner. Renaming package is a big change. The early feedback is better than when everything is ready. |
@Kielek that's right. However it sensible to rename it to match GCP naming convention as they renamed stackdrive long time ago, so when I googled with "gcp traces" / "google cloud open telemetry" i couldn't find it in first place because of name mismatch :) |
@SergeyKanzhelev I implemented now GoogleCloudMetricsExporter to make provider more feature completed, however still not tagging it as ready for review as I would love to get some feedback on this class as it was written with AI support and I am not as familar with Exporters in OTLP. I compared it towards go version: |
Fixes #1170 #1423 #1263
Design discussion issue #
Changes
Changes make sure that package is more aligned with Google naming and using latest version of libraries for GCP connectivity.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes