Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MACsec/ MKA config and metric support in OTG model #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MACsec/ MKA config and metric support in OTG model #408
Changes from all commits
4b20750
8af52f3
3ec23a2
3fd7c48
969df60
1ca1b30
4ecb166
d71380b
6020161
e19f254
ed9acb0
327764c
000d3f6
a413c7f
9a39c19
67ea4ea
36ee718
da773a7
c30ed27
88176bc
53db31b
fef8e24
7b63176
e8108da
dca3c14
c0365c2
fc190d3
0890e5d
e9d7ec0
6733259
0024884
67c50dc
e30bdb7
2e21f36
c682612
a5a2479
a204124
48618c7
7cb2bd8
b6a4544
e1ee4fc
c02214a
a100888
9038f0b
4a1cec9
6901507
9691c0d
77184da
06e35f2
26c52eb
1c28032
f77b401
2b8e2a0
f943b27
e3965fa
bffc9f5
b368302
c9ee3df
13b199c
cd1fec1
06e6b08
f66d227
7e5167a
2f48722
6b6f35c
e2cf5a9
aa80c6f
bc44f82
d9c6248
da33063
0b57649
64f32d5
b28f43b
39d324f
a69e292
9fedae5
db520d7
f5db90e
a8bee5b
8023020
59851eb
33e5de8
b2e8778
fc08673
d33b458
69056f1
a0a1b4f
7f82ad2
0f27500
780b3d7
1b41dc4
02ee19e
c0ba31d
f1c2e80
25415fe
2955f9f
5d65901
e0166c7
8e71436
5d8bfcf
2a12cfd
b5ac0e0
04f0cfb
e6e5f2a
03425e2
8ee499f
5baf6cc
cf26444
2aa3a31
69cc3ce
b284c0e
48d4214
97e9f36
65f7aaa
c3d0e5b
a69b928
96d55d5
3a106d4
03321c2
5a14561
126ddd8
efe91cd
f2467b4
c0a25e1
7223c61
cdb1903
2c0a98d
841689b
3f62b11
c7e7002
9b510eb
3c8f3c5
419101f
dc462a8
6fe78aa
90ab155
c7f349c
2f0706f
61c2c21
fd682c4
f1f8ac0
12d37c6
ddff1fb
93cb804
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we possible have a choice maybe at this level or for both tx/rx within secy to choose either static or mka , and depending on that take in the static or mka config ? At device level , we have single macsec protocol node and within that per interface ( or per interface tx and rx ) we have a choice of static or mka .
Advantage : No ambiguity e.g. if both static and mka are defined for same interface ; association with ethernet interface at single point instead of 2 places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently configuration is arranged this way:
Currently configurations common to static key and MKA are not duplicated. These are set once only. If we have static key and MKA choices at secY or Tx/ Rx level - common configurations in Tx/ Rx will be repeated and any change in model/ test script in common config needs to be done twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to discuss this with some you and some other MacSec stakeholders if possible. Need to also discuss if external ( to Keysight ) is planned for this model or has been done. Ideally prefer validations to be built in into model where possible not allowing users to make mistakes at compile time itself. Not sure on this. Need to also see what are the number of common parameters you describe.