Skip to content

Fixes missing inputType attribute warning from EditTexts #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fixes missing inputType attribute warning from EditTexts #1379

merged 1 commit into from
Jun 9, 2023

Conversation

rchtgpt
Copy link
Member

@rchtgpt rchtgpt commented Jun 6, 2023

Issue Fix

Fixes #473

Description

Added missing inputType attributes for remaining EditTexts based on the action item

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@rchtgpt rchtgpt requested a review from luckyman20 June 6, 2023 07:34
Copy link
Collaborator

@luckyman20 luckyman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luckyman20 luckyman20 merged commit 5f05b5a into openMF:dev Jun 9, 2023
@rchtgpt rchtgpt deleted the add-missing-inputType-on-EditTexts branch June 13, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing inputType attribute for some EditTexts
2 participants