-
Notifications
You must be signed in to change notification settings - Fork 4.2k
add a github action to test the nix flake works and doesn't break #2527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jessie Frazelle <[email protected]>
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
I will also fix the flake... since it's broken. |
Signed-off-by: Jessie Frazelle <[email protected]>
Cool it works now. |
if this breaks again once you have the github action, o3 is great at unfucking these things, but also you can ping me |
Signed-off-by: Jessie Frazelle <[email protected]>
Signed-off-by: Jessie Frazelle <[email protected]>
Interested in this as well, gentle ping for review @tibo-openai 🙏 |
lockFile = ./Cargo.lock; | ||
# ratatui is patched via git, so we must whitelist its fixed-output hash | ||
outputHashes = { | ||
"ratatui-0.29.0" = "sha256-HBvT5c8GsiCxMffNjJGLmHnvG77A6cqEL+1ARurBXho="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this cannot be managed by dependabot or any automated system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah its super unfortunate, and according to our mutual friend, o3, this seems like the lesser of evils...
I presume you all plan on getting your changes merged to ratatui upstream, that would definitely clean it up. But I'm also happy to help, this flake is a part of my dotfiles now, so you all can ping me whenever the action breaks, honestly I'd much prefer being pinged than the flake not work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Pls excuse the drive-by commenting)
If you do want to maintain this long term, you can write a small script that does something to the effect of nix-prefetch-url --unpack --type sha256 $URL
and writes it into something like foo.nix
then do import ./foo.nix
there. Give or take some datastructure adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya that seems like a lot of extra work for something where there hasnt been changes in 3 weeks: https://github.com/nornagon/ratatui/tree/nornagon-v0.29.0-patch I'd like to better understand the plans to upstream
Co-authored-by: Kamil Zabielski <[email protected]>
Co-authored-by: Kamil Zabielski <[email protected]>
Co-authored-by: Kamil Zabielski <[email protected]>
Co-authored-by: Kamil Zabielski <[email protected]>
Co-authored-by: Kamil Zabielski <[email protected]>
Co-authored-by: Kamil Zabielski <[email protected]>
I think your nix flake is broken and this will:
Relevant issue: #241