Skip to content

Conversation

jessfraz
Copy link

@jessfraz jessfraz commented Aug 20, 2025

I think your nix flake is broken and this will:

  1. Prove it
  2. Ensure it doesn't break again
  3. Fix it

Relevant issue: #241

Copy link

github-actions bot commented Aug 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jessfraz
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 20, 2025
@jessfraz
Copy link
Author

I will also fix the flake... since it's broken.

Signed-off-by: Jessie Frazelle <[email protected]>
@jessfraz
Copy link
Author

Cool it works now.

@jessfraz
Copy link
Author

if this breaks again once you have the github action, o3 is great at unfucking these things, but also you can ping me

@shekhirin
Copy link

Interested in this as well, gentle ping for review @tibo-openai 🙏

lockFile = ./Cargo.lock;
# ratatui is patched via git, so we must whitelist its fixed-output hash
outputHashes = {
"ratatui-0.29.0" = "sha256-HBvT5c8GsiCxMffNjJGLmHnvG77A6cqEL+1ARurBXho=";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this cannot be managed by dependabot or any automated system.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah its super unfortunate, and according to our mutual friend, o3, this seems like the lesser of evils...

I presume you all plan on getting your changes merged to ratatui upstream, that would definitely clean it up. But I'm also happy to help, this flake is a part of my dotfiles now, so you all can ping me whenever the action breaks, honestly I'd much prefer being pinged than the flake not work :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Pls excuse the drive-by commenting)

If you do want to maintain this long term, you can write a small script that does something to the effect of nix-prefetch-url --unpack --type sha256 $URL and writes it into something like foo.nix then do import ./foo.nix there. Give or take some datastructure adjustments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya that seems like a lot of extra work for something where there hasnt been changes in 3 weeks: https://github.com/nornagon/ratatui/tree/nornagon-v0.29.0-patch I'd like to better understand the plans to upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants