Add subagents mock #2602
Draft
Add subagents mock #2602
+306
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
reviewed
Aug 23, 2025
|
|
||
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, TS)] | ||
| #[serde(rename_all = "snake_case")] | ||
| pub struct Finding { |
There was a problem hiding this comment.
Suggested change
| pub struct Finding { | |
| pub struct ReviewItem { |
Any reason to not make this parallel with Review?
There was a problem hiding this comment.
The tool prompt
| pub struct Finding { | ||
| pub title: String, | ||
| pub body: String, | ||
| pub confidence_score: f32, |
There was a problem hiding this comment.
what does 0-1 mean?
There was a problem hiding this comment.
The confidence score. That's what the code review system prompt says, at least
|
@easong-openai (we chatted offline), could you validate that the subagents work here is aligned with what you had in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mock for adding subagents