Skip to content

feat(dotnet-sdk): configurable client credentials token url #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alex-zyl
Copy link

@alex-zyl alex-zyl commented Mar 5, 2025

Description

Makes token endpoint configurable.

References

#238

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@alex-zyl alex-zyl requested a review from a team as a code owner March 5, 2025 18:30
Copy link

linux-foundation-easycla bot commented Mar 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alex-zyl / name: Alex Zyl (a203e06)

@alex-zyl alex-zyl force-pushed the feature/238-configurable-token-issuer branch from 5231b3f to a203e06 Compare March 5, 2025 18:33
@rhamzeh rhamzeh self-assigned this Mar 17, 2025
@rhamzeh
Copy link
Member

rhamzeh commented Mar 17, 2025

Thanks for the PR @alex-zyl - sorry it's taking a bit longer to review, we're clearing through a backlog of .NET related changes and PRs and hopefully this week or early next week we can get this reviewed and merged

@alex-zyl
Copy link
Author

No worries, @rhamzeh

Luckily the issue with hardcoded token endpoint subpath can be workedaround by providing own instance of http client where we can overwrite request url

@jamp-scp28
Copy link

Hey @alex-zyl, just an opinion; but seems to me we're not addressing the root issue, a better solution should involve Discovery, it might require some work though.

On the other hand, if a workaround is to be provided, I think the PR might introduce edge cases and breaking changes on clients relying already on that PathTemplate; just and idea but why just not adding a new variable to the ClientConfiguration.Credentials and use it for the PathTemplate if not null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants