-
Notifications
You must be signed in to change notification settings - Fork 35
Replayer logging changes #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replayer logging changes #1463
Conversation
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
TrafficCapture/trafficReplayer/src/main/resources/log4j2.properties
Outdated
Show resolved
Hide resolved
TrafficCapture/trafficReplayer/src/main/resources/log4j2.properties
Outdated
Show resolved
Hide resolved
TrafficCapture/trafficReplayer/src/main/resources/log4j2.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Andre Kurait <[email protected]>
@mikaylathompson, i've made some updates for the default config here: mikaylathompson#6 Let me know what you think |
...cCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mikayla Thompson <[email protected]>
This reverts commit 54d5c46. Signed-off-by: Mikayla Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two considerations, but if @AndreKurait and @mikaylathompson are happy with this I'm fine to merge.
1/ Should these changes be replicated in the RFS logger?
2/ The complexity of this file is growing, almost seems like having a script/programmatic construction would be useful for reuse
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Behavior is as follows:
This PR initially included code that looked for an env var to decide which log4j2 properties file to use. It turns out that exists natively in Log4j, so we're using that instead.
Issues Resolved
Testing
Testing needed! Discussed with @gregschohn to add tests that validate the new logging properties file path behavior, especially when the file doesn't exist.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.