Include Stage name in emitted metrics and dashboards #1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
peternied,
sumobrian and
jugal-chauhan
as code owners
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
gregschohn
reviewed
Apr 30, 2025
TrafficCapture/dockerSolution/src/main/docker/otelCollector/otel-config-aws.yaml
Outdated
Show resolved
Hide resolved
TrafficCapture/dockerSolution/src/main/docker/otelCollector/otel-config-aws.yaml
Outdated
Show resolved
Hide resolved
TrafficCapture/dockerSolution/src/main/docker/otelCollector/otel-config-aws.yaml
Outdated
Show resolved
Hide resolved
| action: delete | ||
| - key: telemetry.sdk.name | ||
| action: delete | ||
| - key: telemetry.sdk.version |
There was a problem hiding this comment.
I think that I'm fine with this, but it also seems like it might be a premature optimization. Won't they generally be the same value until there was an upgrade? If there was an upgrade, numbers could be slightly off - and it would be good to know that this is why. That said, there are plenty of other data provenance values that are not included in these metric dimensions.
There was a problem hiding this comment.
This drastically simplified the changes to the dashboards, by only adding qualifer instead of the other attributes as dimensions. I'd prefer to keep this for now and later add back in.
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
| awsxray: | ||
| index_all_attributes: true | ||
| service: | ||
| extensions: [health_check] | ||
| pipelines: | ||
| metrics: | ||
| receivers: [otlp] | ||
| processors: [batch] | ||
| processors: [cumulativetodelta, resource/metrics, batch] |
There was a problem hiding this comment.
What do we mean by adding these?
There was a problem hiding this comment.
This adds in the qualifier attribute with resource/metrics and cumulativetodelta converts cumulative metrics to delta such as histogram which show the total aggregate since a process was started to just the delta in the last minute
deployment/cdk/opensearch-service-migration/lib/constructs/migration-dashboard.ts
Outdated
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/components/capture-replay-dashboard.json
Outdated
Show resolved
Hide resolved
deployment/cdk/opensearch-service-migration/lib/components/capture-replay-dashboard.json
Outdated
Show resolved
Hide resolved
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
changed the title
AndreKurait
commented
May 7, 2025
| @@ -58,6 +63,10 @@ export class OtelCollectorSidecar { | |||
| } | |||
| }); | |||
| taskDefinition.addToTaskRolePolicy(createAwsDistroForOtelPushInstrumentationPolicy()); | |||
| taskDefinition.defaultContainer?.addContainerDependencies({ | |||
There was a problem hiding this comment.
Fixes Failed to export metrics observed during normal deployment cycle
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add stage name to metrics with trace sampling.
Fix dependency ordering with otel collector and service container, fixes otel sdk connection error during task shutdown / startup when the service is running without the collector.
Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1949
Testing
Verified metrics with dimension and dashboards in jenkins environment
C&R Dashboard Example:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.