Skip to content

[NPUW] Fix serialization #31496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

[NPUW] Fix serialization #31496

merged 2 commits into from
Jul 28, 2025
+4 −2

Conversation

smirnov-alexey
Copy link
Contributor

Bug introduced here #31294

@smirnov-alexey smirnov-alexey added this to the 2025.3 milestone Jul 28, 2025
@smirnov-alexey smirnov-alexey requested review from a team as code owners July 28, 2025 12:26
@github-actions github-actions bot added category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Jul 28, 2025
@AsyaPronina
Copy link
Contributor

Could you please also fix a Coverity issue in that PR, if you have time?
Since this constructor is public: https://github.com/openvinotoolkit/openvino/pull/31496/files#diff-7c0906d2d24827a3f37868e79470c1a41ea4bf66eae148a462c0442f8e9cc191R1191, some user can use it accidentially and we need m_prefill_chunk_size to be initialized here, could you please initialize it with 0 value in constructor initializer list?

@smirnov-alexey smirnov-alexey enabled auto-merge July 28, 2025 18:04
@smirnov-alexey smirnov-alexey added this pull request to the merge queue Jul 28, 2025
Merged via the queue into openvinotoolkit:master with commit d6983f6 Jul 28, 2025
179 checks passed
@smirnov-alexey smirnov-alexey deleted the as/npuw_fix_chunk_s11n branch July 28, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsyaPronina AsyaPronina AsyaPronina approved these changes

Assignees

@AsyaPronina AsyaPronina

Labels
category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin
Projects
None yet
Milestone
2025.3
Development

Successfully merging this pull request may close these issues.
2 participants
@smirnov-alexey @AsyaPronina