Skip to content

fix(log): display correct repository paths in log #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

j-g00da
Copy link
Contributor

@j-g00da j-g00da commented Jun 23, 2025

Description

Base path is second parameter of pathdiff::diff_paths.

Motivation and Context

Partially f*xes #1187

How Has This Been Tested?

Just vibes

Screenshots / Logs (if applicable)

cargo run -- --repository ../ratatui ../mousefood

Before:

 INFO  git_cliff > Including changes from the current directory: "../git-cliff"
 INFO  git_cliff > Including changes from the current directory: "../git-cliff"

After:

 INFO  git_cliff > Including changes from the current directory: "../ratatui"
 INFO  git_cliff > Including changes from the current directory: "../mousefood"

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@j-g00da j-g00da requested a review from orhun as a code owner June 23, 2025 17:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.92%. Comparing base (6db7d49) to head (5e2d6a0).

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1188   +/-   ##
=======================================
  Coverage   41.92%   41.92%           
=======================================
  Files          21       21           
  Lines        2009     2009           
=======================================
  Hits          842      842           
  Misses       1167     1167           
Flag Coverage Δ
unit-tests 41.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun
Copy link
Owner

orhun commented Jun 25, 2025

thanks!

@orhun orhun merged commit ff6c310 into orhun:main Jun 25, 2025
86 checks passed
Copy link

welcome bot commented Jun 25, 2025

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants