Skip to content

(PyKDL) expose ChainExternalWrenchEstimator #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NRRHHH
Copy link

@NRRHHH NRRHHH commented Jun 27, 2025

Also add .gitignore.

@MatthijsBurgh
Copy link
Collaborator

Please also copy the relevant tests from cpp to python

@MatthijsBurgh
Copy link
Collaborator

Please create a separate commit for the .gitignore file

@PeterBowman PeterBowman force-pushed the py-chainexternalwrenchestimator branch from 72fdcaf to 61b527e Compare July 14, 2025 14:38
@PeterBowman
Copy link

Please create a separate commit for the .gitignore file

Done.

Please also copy the relevant tests from cpp to python

This might take some time since tests for ChainExternalWrenchEstimator are coupled with other tests which are also missing.

@PeterBowman PeterBowman force-pushed the py-chainexternalwrenchestimator branch from 61b527e to c971ec6 Compare July 18, 2025 08:15
@MatthijsBurgh
Copy link
Collaborator

@PeterBowman Are you planning to add the tests? I don't want to add features without adding tests.

@PeterBowman
Copy link

@MatthijsBurgh sure, I was a bit busy, next week I'll get back at this. As I noted before, this class is coupled with several other solvers in solvertest.cpp, which are currently not covered in kinfamtest.py. In order to translate ChainExternalWrenchEstimator's C++ test cases to Python, it seems to be necessary to add tests for those other classes, too. Is this correct?

@MatthijsBurgh
Copy link
Collaborator

When a test case is repeated for multiple solvers, it would be preferable to copy them all to python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants