Skip to content

fix(linter/jsx-key): check if element in push call #12986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PeterCardenas
Copy link
Contributor

react/jsx-key should check if the jsx element is inside an Array.prototype.push call. This PR adds support for checking that.

@PeterCardenas PeterCardenas requested a review from camc314 as a code owner August 11, 2025 08:56
Copy link
Contributor

graphite-app bot commented Aug 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Aug 11, 2025
Copy link

codspeed-hq bot commented Aug 11, 2025

CodSpeed Instrumentation Performance Report

Merging #12986 will not alter performance

Comparing PeterCardenas:check-jsx-key-in-push (be075cb) with main (1b0136e)

Summary

✅ 34 untouched benchmarks

[autofix.ci] apply automated fixes
@PeterCardenas PeterCardenas force-pushed the check-jsx-key-in-push branch from b650387 to be075cb Compare August 11, 2025 09:35
@camc314 camc314 self-assigned this Aug 11, 2025
@Sysix
Copy link
Member

Sysix commented Aug 11, 2025

@camc314 the upstream plugin has an PR for this too: jsx-eslint/eslint-plugin-react#3938
I would prefer to wait how they are linting it (with option or by default)

@camc314 camc314 marked this pull request as draft August 13, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants