-
-
Notifications
You must be signed in to change notification settings - Fork 259
Remove trailing space from build script #1987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch for hacktoberfest haha :)
Totally useless as PR but just for the research I accept it :D
Oops you have to merge conflicts before ^^ |
Haha! That wasn't the motivation here. I almost did this in my other PR (#1934), because that's where I experienced the problem that motivated this change (5ccc1e0), but I was doing my best to follow the contributing guidelines. 😉
But yeah, it probably could/should have been incorporated into my other PR. 😄 |
cd635a8
to
c381472
Compare
I'm not seeing any merge conflicts 👀 |
@parkerbxyz please can you make your branch up to date with main ? it will fix CI issues not related to your PR :) |
Codecov Report
@@ Coverage Diff @@
## main #1987 +/- ##
==========================================
+ Coverage 82.68% 82.71% +0.02%
==========================================
Files 157 157
Lines 3384 3384
==========================================
+ Hits 2798 2799 +1
+ Misses 586 585 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Many editors are configured to trim trailing whitespace upon saving files. When this happens, it can often clutter up diffs with whitespaces changes.
Proposed Changes
Remove trailing space from build script to ensure trailing spaces don't end up in files generated/edited by the build script.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance