Skip to content

Remove trailing space from build script #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

parkerbxyz
Copy link
Contributor

Many editors are configured to trim trailing whitespace upon saving files. When this happens, it can often clutter up diffs with whitespaces changes.

Proposed Changes

Remove trailing space from build script to ensure trailing spaces don't end up in files generated/edited by the build script.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch for hacktoberfest haha :)
Totally useless as PR but just for the research I accept it :D

@nvuillam
Copy link
Member

Oops you have to merge conflicts before ^^

@parkerbxyz
Copy link
Contributor Author

parkerbxyz commented Oct 22, 2022

Good catch for hacktoberfest haha :) Totally useless as PR but just for the research I accept it :D

Haha! That wasn't the motivation here. I almost did this in my other PR (#1934), because that's where I experienced the problem that motivated this change (5ccc1e0), but I was doing my best to follow the contributing guidelines. 😉

Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.

But yeah, it probably could/should have been incorporated into my other PR. 😄

@parkerbxyz parkerbxyz marked this pull request as ready for review October 22, 2022 01:39
@parkerbxyz parkerbxyz marked this pull request as draft October 22, 2022 01:39
@parkerbxyz parkerbxyz force-pushed the remove-trailing-space branch from cd635a8 to c381472 Compare October 22, 2022 01:42
@parkerbxyz parkerbxyz marked this pull request as ready for review October 22, 2022 01:44
@parkerbxyz
Copy link
Contributor Author

Oops you have to merge conflicts before ^^

I'm not seeing any merge conflicts 👀

@nvuillam
Copy link
Member

@parkerbxyz please can you make your branch up to date with main ? it will fix CI issues not related to your PR :)

@codecov-commenter
Copy link

Codecov Report

Merging #1987 (8e215cf) into main (e957998) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
+ Coverage   82.68%   82.71%   +0.02%     
==========================================
  Files         157      157              
  Lines        3384     3384              
==========================================
+ Hits         2798     2799       +1     
+ Misses        586      585       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvuillam nvuillam merged commit f50a16b into oxsecurity:main Oct 23, 2022
@parkerbxyz parkerbxyz mentioned this pull request Apr 14, 2025
4 tasks
@parkerbxyz parkerbxyz deleted the remove-trailing-space branch April 14, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants