null checks

[parmesant]

Fixes #XXXX.

Description

A previous PR modified the conditions config to make the value field nullable. But the frontend is sometimes sending an empty string in case of null. This PR performs both the checks and rejects the request in case the operator is is null or is not null and the value is something other than null or an empty string.

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• Bug Fixes
  • Improved validation to ensure empty or whitespace-only strings are no longer treated as valid values in alert filters and configuration checks.
  • Enhanced filter message generation to exclude empty or whitespace-only strings, resulting in clearer and more accurate alert messages.

[coderabbitai]

Walkthrough

The changes strengthen the validation of optional string values in alert-related logic. Functions and methods now check that string values are not only present but also non-empty and not just whitespace. This adjustment applies to filter string generation, operator matching, and configuration validation, ensuring empty or whitespace-only strings are not treated as valid inputs.

Changes

File(s)	Change Summary
src/alerts/alerts_utils.rs	Enhanced checks in get_filter_string and match_alert_operator to ignore empty/whitespace strings.
src/alerts/mod.rs	Updated Conditions::generate_filter_message and AlertConfig::validate_configs to treat empty/whitespace strings as missing values.

Poem

In the land of alerts where the rabbits hop,
Strings must be sturdy—no blanks in the crop!
Whitespace and empties are now cast aside,
Only true values may burrow inside.
With stricter checks, the warnings ring clear,
Hooray for clean carrots—no fluff to fear! 🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3c402d and b26a1e4.

📒 Files selected for processing (2)

• src/alerts/alerts_utils.rs (2 hunks)
• src/alerts/mod.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: coverage
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments

🔇 Additional comments (6)

src/alerts/alerts_utils.rs (3)

350-354: LGTM! Improved validation prevents empty/whitespace values from being processed.

The enhanced check using is_some_and(|v| !v.trim().is_empty()) correctly treats empty or whitespace-only strings as invalid, which aligns with the PR's objective to strengthen null checks.

---

362-364: Safe unwrap after validation.

The unwrap() call is safe here since the preceding condition ensures the value is Some and non-empty after trimming.

---

396-397: Consistent validation improvement applied.

The same enhanced validation pattern is correctly applied here, ensuring consistent behavior across the codebase when dealing with optional string values.

src/alerts/mod.rs (3)

346-352: Enhanced message formatting with proper validation.

The improved validation ensures that only meaningful (non-empty, non-whitespace) values are included in filter messages, preventing confusing output from empty string values.

---

357-363: Consistent validation applied to second expression.

The same validation logic is correctly applied to expr2, maintaining consistency in message formatting behavior.

---

674-679: Critical validation improvement for null operators.

This change correctly treats empty/whitespace strings as "no value" when validating operators like IsNull and IsNotNull. This prevents false validation errors and ensures logical consistency where empty strings are equivalent to null values in this context.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.