Skip to content

feat: add experimental require_file function to mark externally mounted files as required at runtime #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 7, 2025

Conversation

dionhaefner
Copy link
Contributor

Relevant issue or PR

Another option to implement the functionality from #254. Not saying this is the way to go, but perhaps it can guide the discussion on which design we're looking for.

Description of changes

  • Add tesseract_core.runtime.experimental.require_file function that Tesseract creators can use to mark files as required at runtime, but not at build time.

Testing done

CI

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.51%. Comparing base (8d409fe) to head (bdc51ba).

Files with missing lines Patch % Lines
tesseract_core/runtime/cli.py 46.15% 5 Missing and 2 partials ⚠️
tesseract_core/runtime/experimental.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   78.08%   77.51%   -0.57%     
==========================================
  Files          29       29              
  Lines        3253     3274      +21     
  Branches      506      511       +5     
==========================================
- Hits         2540     2538       -2     
- Misses        486      504      +18     
- Partials      227      232       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@llueg llueg marked this pull request as ready for review August 5, 2025 20:10
@llueg llueg requested review from xalelax and apaleyes as code owners August 5, 2025 20:10
Copy link
Contributor

@xalelax xalelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionhaefner
Copy link
Contributor Author

Thanks @llueg!

@dionhaefner dionhaefner enabled auto-merge (squash) August 7, 2025 19:55
@dionhaefner dionhaefner disabled auto-merge August 7, 2025 19:55
@dionhaefner dionhaefner changed the title feat: alternative implementation for file requirements feat: add experimental require_file function to mark externally mounted files as required at runtime Aug 7, 2025
@dionhaefner dionhaefner enabled auto-merge (squash) August 7, 2025 19:56
@dionhaefner dionhaefner merged commit c987046 into main Aug 7, 2025
40 checks passed
@dionhaefner dionhaefner deleted the dion/require-files-alternative branch August 7, 2025 20:08
@pasteurlabs pasteurlabs locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants