-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add experimental require_file
function to mark externally mounted files as required at runtime
#261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 78.08% 77.51% -0.57%
==========================================
Files 29 29
Lines 3253 3274 +21
Branches 506 511 +5
==========================================
- Hits 2540 2538 -2
- Misses 486 504 +18
- Partials 227 232 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
llueg
reviewed
Jul 30, 2025
dionhaefner
commented
Jul 31, 2025
xalelax
reviewed
Aug 6, 2025
xalelax
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dionhaefner
commented
Aug 6, 2025
dionhaefner
commented
Aug 6, 2025
dionhaefner
commented
Aug 6, 2025
dionhaefner
commented
Aug 6, 2025
dionhaefner
commented
Aug 6, 2025
Co-authored-by: Dion Häfner <[email protected]>
Co-authored-by: Dion Häfner <[email protected]>
Co-authored-by: Dion Häfner <[email protected]>
dionhaefner
commented
Aug 7, 2025
dionhaefner
commented
Aug 7, 2025
dionhaefner
commented
Aug 7, 2025
dionhaefner
commented
Aug 7, 2025
dionhaefner
commented
Aug 7, 2025
Thanks @llueg! |
require_file
function to mark externally mounted files as required at runtime
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
Another option to implement the functionality from #254. Not saying this is the way to go, but perhaps it can guide the discussion on which design we're looking for.
Description of changes
tesseract_core.runtime.experimental.require_file
function that Tesseract creators can use to mark files as required at runtime, but not at build time.Testing done
CI