fix: Use --input-path/--output-path as base_dir in json+binref encoder
#304
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 78.39% 71.94% -6.45%
==========================================
Files 29 29
Lines 3249 3240 -9
Branches 501 500 -1
==========================================
- Hits 2547 2331 -216
- Misses 484 697 +213
+ Partials 218 212 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems like |
|
Thanks, I can take it from here! |
There was a problem hiding this comment.
Those functions were a bit bare-bones after the msgpack deprecation, inlined instead.
| param=InputSchema, | ||
| param_hint=InputSchema.__name__, | ||
| param_hint="payload", |
There was a problem hiding this comment.
Drive-by change: wrong usage
| @@ -628,7 +628,7 @@ def serve( | |||
| logger.info( | |||
| f"Tesseract container name, use it with 'tesseract teardown' command: {container_name}" | |||
| ) | |||
| container_meta = {"container_name": container_name, "containers": container_ports} | |||
| container_meta = {"container_name": container_name, "containers": [container_ports]} | |||
There was a problem hiding this comment.
Drive-by change: "containers" implies a collection, not a singular value, so I turned it into a list here.
| @@ -548,6 +512,113 @@ def serve_tesseract(): | |||
| assert (tmp_path / "bar").exists() | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("method", ["run", "serve"]) | |||
| @pytest.mark.parametrize("array_format", ["json", "json+base64", "json+binref"]) | |||
| def test_io_path_interactions( | |||
There was a problem hiding this comment.
Meat of this PR, the new test ensures everything is e2e consistent across all formats and modes of invocation.
| @@ -650,39 +721,6 @@ def _get_host_ip(): | |||
| requests.get(f"http://localhost:{container.host_port}/health") | |||
|
|
|||
|
|
|||
| def test_tesseract_cli_options_parsing(built_image_name, tmpdir): | |||
| @@ -724,8 +762,8 @@ def apply(inputs: InputSchema) -> OutputSchema: | |||
| docker_cleanup["images"].append(img_tag) | |||
|
|
|||
|
|
|||
| def logging_tesseract_api_string(): | |||
| return dedent( | |||
| def build_logging_tesseract(workdir): | |||
Co-authored-by: Niklas Heim <[email protected]>
Relevant issue or PR
When passing
json+binrefencoded payloads to a tesseract, thebase_dir(which stores the .bin files) was not set.This would not be an issue if the payload would be encoded with a proper
InputFileReference, but I don't think we can assume this in all cases.Description of changes
Use input path/output path as the default for
base_dir(if it is not explicitly set)Testing done
CI passes.