fix: adds enableStatusLocalization option to reflects current locale across UI #13207
+224
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessrynkar
requested review from
jacobsfletch,
AlessioGr and
JarrodMFlesch
as code owners
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
DanRibbens
reviewed
Jul 17, 2025
| }), | ||
| for (let i = 0; i < result.docs.length; i++) { | ||
| const id = result.docs[i].parent | ||
| console.log(result.docs[i]) |
DanRibbens
reviewed
Jul 17, 2025
| name: code, | ||
| type: 'select', | ||
| options: [ | ||
| { label: 'Draft', value: 'draft' }, |
There was a problem hiding this comment.
Should use translations for the labels. We have a function for this.
DanRibbens
reviewed
Jul 17, 2025
| disabled: true, | ||
| }, | ||
| fields: localeStatusFields, | ||
| index: true, |
There was a problem hiding this comment.
indexing on the group itself won't do much. We likely want the subfields to be index: true instead.
DanRibbens
reviewed
Jul 17, 2025
| @@ -56,6 +56,35 @@ export const buildVersionGlobalFields = <T extends boolean = false>( | |||
| return locale.code | |||
| }), | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
What is the difference here vs the collection version fields added in this change? Can we write once and import or get the field from one function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new
enableStatusLocalizationconfig option. When enabled, the admin panel will display the document status based on the current locale instead of the latest overall status. Also updates the edit view to only show achangedstatus whenautosaveis enabled.Why?
Showing the status for the current locale is more accurate and useful in multi-locale setups. While this would make sense as the default, it's opt-in to avoid breaking changes for existing users.
How?
When
enableStatusLocalizationistrue, we store per-locale status in a newlocaleStatusfield group within version data. The admin panel then reads from this field to display the correct status for the current locale.