-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(next): add missing translations to version view #13208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(next): add missing translations to version view #13208
Conversation
Head branch was pushed to by a user without write access
Test was failing due to mismatched casing. An e2e locator in the versions suite was trying to find an exact "Block 01" but the translated label is "block". I changed the test to look for a lowercase label but here are some other options:
|
Hmmmm I'm not so sure about this change then. A quick search is showing that translation is used only within the blocks field for row actions, etc. I'd rather explore how capitalization might impact these instances, and if needed, create a new translation key specifically for this. Unless there's a better way. |
I reverted the test change and proceeded with just capitalizing the translation outright. I noticed that some translations are inconsistent across languages though, with some already being capitalized and others not. Should I correct the translations to be consistent here? Should I do the same for array items? Open to suggestions & thoughts. |
Yea I see what you mean. They should all be consistent across languages. Might want to also do the same with |
What?
This PR translates the block and item label in the version view, as well as the version label in the step nav.
Why?
To appropriately translate labels in the version views.
How?
By using the TFunction from useTranslation as well as existing translation keys.
Fixes #13193
Fixes #13194