Caf fixes #385
Open
Caf fixes #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can have compressed formats with fixed packets sizes this means that we need to separate by packet type not by compressed or not. This replaces the check with a varible packet size check and enables the demuxing of compressed fixed packets. Uncompressed data is chunked into MAX_FRAMES_PER_PACKET while compressed data packets are read one packet at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed for caf files containing ima4 audio. Main change is moving away from compresses/uncompressed to variable\fixed packet parsing. I've tested with the sample files that worked previously as well as the caf ima4 file I have locally and it seems to work. Let me know if I missed anything or should change something!