allow to customize json search function #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstdio
requested changes
Aug 18, 2025
rsql-jpa/src/main/java/io/github/perplexhub/rsql/jsonb/JsonbSupport.java
Outdated
Show resolved
Hide resolved
nstdio
requested changes
Aug 27, 2025
rsql-jpa/src/main/java/io/github/perplexhub/rsql/jsonb/JsonbExtractor.java
Outdated
Show resolved
Hide resolved
| @Builder | ||
| @Accessors(fluent = true) | ||
| @Getter | ||
| public class JsonbExtractorSupport implements JsonbExtractor { |
There was a problem hiding this comment.
Actually, can we use record here?
There was a problem hiding this comment.
with record im unable to use initilizing expressions with default values for lombok builder as it is now:
@Builder.Default
private final String pathExists = JsonbConfiguration.DEFAULT.pathExists()
There was a problem hiding this comment.
I guess this would address that https://stackoverflow.com/a/76107286
rsql-jpa/src/main/java/io/github/perplexhub/rsql/jsonb/JsonbExpressionBuilder.java
Outdated
Show resolved
Hide resolved
nstdio
requested changes
Aug 29, 2025
| /** | ||
| * jsonb expression configuration | ||
| */ | ||
| public interface JsonbConfiguration { |
There was a problem hiding this comment.
Do we really need it be an interface?
At the first glance I'm unable to see what benefit, flexibility or extensibility we gain by enabling client code to implement this interface. The configuration part is done via JsonbConfigurationSupport and that's that. Perhaps we should rename JsonbConfigurationSupport to JsonbConfiguration and remove the interface? wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #187