Skip to content

added multistage docker builds with docker instructions in readme #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heywoodlh
Copy link

Hi

I made some improvements to the Docker build:

  • Multistage builds should reduce the size of the image (and decrease vulnerabilities)
  • Removed hardcoding the version of nfdump
  • Separate targets for nfcapd and nfdump (i.e. one target for being the server and one for the client)
  • Copy the repo source into the image instead of downloading and extracting an archive of nfdump
  • Added documentation for building the image (Alpine being the assumed base build)

Please let me know if I can clarify anything with these changes. :) Thanks for the great project.

@heywoodlh heywoodlh force-pushed the docker-multistage-builds branch from c87729f to 1d3ca46 Compare April 30, 2025 04:28
Copy link
Owner

@phaag phaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.
Would you mind to create a readme.md file in the docker directory and copy the instructions there, reducing the primary readme with a reference to the docker readme?
Furthermore, don't hesitate to put your name and email as the contributor to the docker readme. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants