[#noissue] Remove Jdk17Utils.assumeFalse #12237
Open
+3
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the obsolete Jdk17Utils.assumeFalse utility and updates tests accordingly. The changes ensure tests no longer rely on the removed utility method, update assertion argument ordering for clarity, and switch to parameterized logging for improved readability.
- Removed the Jdk17Utils utility class from the test suite.
- Removed assumeFalse calls in FuzzyRowKeyBuilderTest and FuzzyRowFilterTest.
- Updated assertions and logging in FuzzyRowFilterTest.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| commons-server/src/test/java/com/navercorp/pinpoint/common/server/scatter/Jdk17Utils.java | Removed the obsolete utility class. |
| commons-server/src/test/java/com/navercorp/pinpoint/common/server/scatter/FuzzyRowKeyBuilderTest.java | Removed unnecessary calls to assumeFalse to reflect the removal of Jdk17Utils. |
| commons-server/src/test/java/com/navercorp/pinpoint/common/server/scatter/FuzzyRowFilterTest.java | Removed assumeFalse calls, reorganized assertion parameters for clarity, and improved logging by using parameterized messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.