Use Temurin (OpenJDK) instead of Zulu #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure. I like Zulu. Have used it professionally and in OSS for years. The byte code generated should be equivalent. If we are going to get into disagreements over what is the best JDK, then there are other ones that could be considered. |
|
For me its more about being consistent with using the same JDK (in our case Temurin) across the entire Pekko ecosystem. At least when it comes to Scala OS project everyone has settled with Temurin (this is also the case with akka iirc). Its not a huge deal so I will leave it up to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Zulu is probably fine, its preferable to use OpenJDK build such as Temurin especially for publishing (and this library is being used by Pekko). @pjfanning