Refactor: move Refresh Token generation logic to AccountManagement #758
+55
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The OTP Generator, PasswordHelper, AuthenticationKeys, etc. are and can used by self-contained systems in downstream projects and should stay in SharedKernel. Let's have discussions (on Slack) before we make changes to the architecture, so we are aligned before we make changes to the architecture or implement new features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This Pull Request moves Refresh Token generation logic into Account Management. Only Account Management should generate new Refresh Tokens.
This is a step the first step that will allow Account Management to block Refresh Token replay attempts.
Checklist